[PATCH] D68177: compiler-rt: move all __GLIBC_PREREQ into own header file
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 30 10:54:42 PDT 2019
eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_glibc_version.h:24
+#define __GLIBC_PREREQ(x, y) 0
+#endif
+
----------------
vitalybuka wrote:
> eugenis wrote:
> > Why not put this in sanitizer_platform.h directly?
> looks like it's different from what is defined in platform.h
> also it needs to go after the SANITIZER_POSIX definition.
>
> I have no preference here. Should I change?
>
That would put features.h include in sanitizer_platform.h, which might be bad...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68177/new/
https://reviews.llvm.org/D68177
More information about the llvm-commits
mailing list