[PATCH] D68216: [yaml2obj] - Alow Size tag for describing SHT_HASH sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: lib/ObjectYAML/ELFYAML.cpp:1215
+    if (!HS->Content && !HS->Bucket && !HS->Chain && !HS->Size)
+      return "one of \"Content\", \"Size\", \"Bucket\" and \"Chain\" must be specified";
+
----------------
clang-format?


================
Comment at: lib/ObjectYAML/ELFYAML.cpp:1224
       if (HS->Bucket)
-        return "\"Content\" and \"Bucket\" cannot be used together";
+        return "\"Content\"/\"Size\" and \"Bucket\" cannot be used together";
       if (HS->Chain)
----------------
I might rephrase this and the below message as follows:

"Bucket" cannot be used with "Content" or "Size"


================
Comment at: test/tools/yaml2obj/elf-hash-section.yaml:149
+
+## Check we can use only "Size" to create a hash section.
+
----------------
I'd say "SHT_HASH section" instead of "hash section" mostly to match the phrasing used elsewhere in this test.


================
Comment at: test/tools/yaml2obj/elf-hash-section.yaml:173
+
+## Check we can use "Size" and "Content" together to create a hash section.
+
----------------
Ditto


================
Comment at: test/tools/yaml2obj/elf-hash-section.yaml:197-198
+
+## Check that when "Size" and "Content" are used together then the size
+## must be greater than or equal to the content size
+
----------------
together then the -> together, the

Trailing full stop missing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68216/new/

https://reviews.llvm.org/D68216