[PATCH] D68085: [yaml2obj/obj2yaml] - Add support for SHT_HASH sections.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of minor points.



================
Comment at: lib/ObjectYAML/ELFYAML.cpp:1214
+    if (!HS->Content && !HS->Bucket && !HS->Chain)
+      return "one of \"Content\", \"Bucket\" and \"Chain\" must be specified";
+
----------------
and -> or


================
Comment at: test/tools/yaml2obj/elf-hash-section.yaml:3
+
+## Check we can describe a SHT_HASH section using the "Content" tag
+
----------------
Missing trailing full stop.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68085/new/

https://reviews.llvm.org/D68085