[PATCH] D67125: [PowerPC][AIX] Adds support for writing the data section in object files

Xing Xue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 09:56:49 PDT 2019


xingxue marked an inline comment as done.
xingxue added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:542
+    for (auto &Csect : DataCsects) {
+      const MCSectionXCOFF *MCSec = Csect.MCCsect;
+      Address = alignTo(Address, MCSec->getAlignment());
----------------
hubert.reinterpretcast wrote:
> This is the third copy of this code or thereabouts. At what point are we going to factor this code into a function?
@jasonliu is preparing an NFC patch to common up this code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67125/new/

https://reviews.llvm.org/D67125





More information about the llvm-commits mailing list