[PATCH] D68209: WIP: [LiveDebugValues] Introduce entry values of unmodified/modified params

Mon Sep 30 09:00:47 PDT 2019

aprantl added a comment.

So we've come full circle :-)
I'm not a fan of lumping arbitrary funcitonality into LiveDebugValues, but if we can keep it readable this is probably the best place for it.

================
Comment at: llvm/lib/IR/DebugInfoMetadata.cpp:966

+bool DIExpression::isOpWithOffset() const {
+  if (getNumElements() == 0)
----------------
This appears to be of limited use since many DIExpressions are more complex. Is this meant to detect spill locations? If yes, could we mark them differently when we create them instead of trying to detect them here?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68209/new/

https://reviews.llvm.org/D68209