[PATCH] D68214: [yaml2obj] - Allow specifying custom Link values for SHT_HASH section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 06:19:13 PDT 2019


jhenderson added a comment.

LGTM, with one suggestion.



================
Comment at: test/tools/yaml2obj/elf-hash-section.yaml:154-160
+# LINK: Name: .hash1
+# LINK: Link:
+# LINK-SAME: 123
+
+# LINK: Name: .hash2
+# LINK: Link:
+# LINK-SAME: 1
----------------
The spacing here isn't lined up like it is in the other ones above. I think it should be something like:


```
# LINK:      Name: .hash1
# LINK:      Link:
# LINK-SAME:       123

# LINK:      Name: .hash2
# LINK:      Link:
# LINK-SAME:       1
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68214/new/

https://reviews.llvm.org/D68214





More information about the llvm-commits mailing list