[PATCH] D68186: [FileCheck] Remove implementation types from API

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of minor nits.



================
Comment at: llvm/include/llvm/Support/FileCheck.h:732
+  std::unique_ptr<FileCheckPatternContext> PatternContext;
+  // CXX17 TODO: make this a plain std::vector.
+  std::unique_ptr<std::vector<FileCheckString>> CheckStrings;
----------------
Why not `C++17`?


================
Comment at: llvm/include/llvm/Support/FileCheck.h:736
 public:
-  FileCheck(FileCheckRequest Req) : Req(Req) {}
+  FileCheck(FileCheckRequest Req);
+  ~FileCheck();
----------------
Should this be `explicit`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68186/new/

https://reviews.llvm.org/D68186