[PATCH] D67968: [TableGen] Introduce a generic automaton (DFA) backend

James Molloy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 30 02:56:52 PDT 2019


jmolloy added inline comments.


================
Comment at: llvm/utils/TableGen/DFAEmitter.cpp:210-211
+
+  bool canTransitionFrom(const uint64_t &State);
+  uint64_t transitionFrom(const uint64_t &State);
+};
----------------
majnemer wrote:
> Why do these take references?
Just a hangover from when I used a non-POD datatype as parameter here. Fixed, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67968/new/

https://reviews.llvm.org/D67968





More information about the llvm-commits mailing list