[PATCH] D68033: [llvm-ar] Make paths case insensitive when on windows

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/windows-case.test:18
+# RUN: llvm-ar Trc %t/thin-archive.a %t/lowerCase/file.txt %t/UPPERCASE/FILE.txt
+# RUN: llvm-ar dTP %t/thin-archive.a %t/uppercase/file.txt
+
----------------
gbreynoo wrote:
> grimar wrote:
> > `T` is create a thin archive, why do you need it here? (the test passes without it).
> This was to specifically test thin archive members as they are stored as paths while the "regular archive" members just use a file name. The code path is similar for both cases however, would you prefer it being removed? 
Probably not. I think I've just misunderstoold how this option works together with others. LG.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68033/new/

https://reviews.llvm.org/D68033