[PATCH] D68140: [lldb][clang][modern-type-lookup] Use ASTImporterSharedState in ExternalASTMerger

Mon Sep 30 02:01:13 PDT 2019

teemperor marked 2 inline comments as done.
teemperor added inline comments.

================
Comment at: clang/include/clang/AST/ExternalASTMerger.h:92
   ImporterTarget Target;
+  std::shared_ptr<ASTImporterSharedState> SharedState;

----------------
shafik wrote:
> Can you add a comment explaining what this is and why we need it and how it relates to the `ASTImpoter`.
> 
> It is not obvious just looking the local changes what effect adding this has.
Added a comment how we used the shared state in all created ASTImporters, but the exact effects of having the shared state are explained in the class itself (e.g. helping the lookup in some cases).

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68140/new/

https://reviews.llvm.org/D68140