[PATCH] D68196: [llvm-readobj/llvm-readelf] Delete --arm-attributes (alias for --arch-specific)

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: atanasyan, compnerd, kongyi, peter.smith, rupprecht.
Herald added subscribers: llvm-commits, seiya, kristof.beyls.
Herald added a project: LLVM.

D68110 <https://reviews.llvm.org/D68110> added --arch-specific (supported by GNU readelf) and made
--arm-attributes an alias for it. The tests were later migrated to use
--arch-specific.

Note, llvm-readelf --arch-specific currently just uses llvm-readobj
style output for ARM attributes. The readelf-style output is not
implemented.


Repository:
  rL LLVM

https://reviews.llvm.org/D68196

Files:
  docs/CommandGuide/llvm-readelf.rst
  docs/CommandGuide/llvm-readobj.rst
  test/tools/llvm-readobj/ARM/attribute-conformance-1.s
  test/tools/llvm-readobj/ARM/attribute-conformance-2.s
  tools/llvm-readobj/llvm-readobj.cpp


Index: tools/llvm-readobj/llvm-readobj.cpp
===================================================================
--- tools/llvm-readobj/llvm-readobj.cpp
+++ tools/llvm-readobj/llvm-readobj.cpp
@@ -236,8 +236,6 @@
                               cl::desc("Displays architecture-specific information, if there is any."));
   cl::alias ArchSpecifcInfoShort("A", cl::desc("Alias for --arch-specific"),
                                  cl::aliasopt(ArchSpecificInfo), cl::NotHidden);
-  cl::alias ARMAttributes("arm-attributes", cl::desc("Alias for --arch-specific"),
-                           cl::aliasopt(ArchSpecificInfo), cl::Hidden);
 
   // --mips-plt-got
   cl::opt<bool>
Index: test/tools/llvm-readobj/ARM/attribute-conformance-2.s
===================================================================
--- test/tools/llvm-readobj/ARM/attribute-conformance-2.s
+++ test/tools/llvm-readobj/ARM/attribute-conformance-2.s
@@ -3,8 +3,6 @@
 @ RUN:   | llvm-readobj --arch-specific - | FileCheck %s --check-prefix=CHECK-OBJ
 @ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
 @ RUN:   | llvm-readobj -A - | FileCheck %s --check-prefix=CHECK-OBJ
-@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
-@ RUN:   | llvm-readobj --arm-attributes - | FileCheck %s --check-prefix=CHECK-OBJ
 .eabi_attribute  Tag_conformance, "A.long--non numeric oddity...!!"
 @CHECK:   .eabi_attribute 67, "A.long--non numeric oddity...!!"
 @CHECK-OBJ: Tag: 67
Index: test/tools/llvm-readobj/ARM/attribute-conformance-1.s
===================================================================
--- test/tools/llvm-readobj/ARM/attribute-conformance-1.s
+++ test/tools/llvm-readobj/ARM/attribute-conformance-1.s
@@ -3,8 +3,6 @@
 @ RUN:   | llvm-readobj --arch-specific - | FileCheck %s --check-prefix=CHECK-OBJ
 @ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
 @ RUN:   | llvm-readobj -A - | FileCheck %s --check-prefix=CHECK-OBJ
-@ RUN: llvm-mc -triple armv7-eabi -filetype obj -o - %s \
-@ RUN:   | llvm-readobj --arm-attributes - | FileCheck %s --check-prefix=CHECK-OBJ
 .eabi_attribute  Tag_conformance, "0"
 @CHECK:   .eabi_attribute 67, "0"
 @CHECK-OBJ: Tag: 67
Index: docs/CommandGuide/llvm-readobj.rst
===================================================================
--- docs/CommandGuide/llvm-readobj.rst
+++ docs/CommandGuide/llvm-readobj.rst
@@ -144,9 +144,9 @@
 
 The following options are implemented only for the ELF file format.
 
-.. option:: --arm-attributes
+.. option:: --arch-specific, -A
 
- Display the ARM attributes section. Only applicable for ARM architectures.
+ Display architecture-specific information, e.g. the ARM attributes section on ARM.
 
 .. option:: --demangle, -C
 
Index: docs/CommandGuide/llvm-readelf.rst
===================================================================
--- docs/CommandGuide/llvm-readelf.rst
+++ docs/CommandGuide/llvm-readelf.rst
@@ -28,9 +28,9 @@
 
  Display the address-significance table.
 
-.. option:: --arm-attributes
+.. option:: --arch-specific, -A
 
- Display the ARM attributes section. Only applicable for ARM architectures.
+ Display architecture-specific information, e.g. the ARM attributes section on ARM.
 
 .. option:: --color
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68196.222344.patch
Type: text/x-patch
Size: 3200 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190930/5b4f57f5/attachment.bin>