[PATCH] D63525: LangRef: Attempt to formulate some rules for addrspacecast

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

Sorry for the delay.

I have a few more notes/questions.



================
Comment at: docs/LangRef.rst:2230
+changed. Different address spaces may have different trapping behavior
+when dereferencing an invalid pointer.
+
----------------
Why, "In general,"? Do we have exceptions?


================
Comment at: docs/LangRef.rst:2726
+address space. Possible exceptions may apply if the operation is
+``volatile``.
 
----------------
Again, why "possible" and "may". Don't we "just" want to say "Exceptions apply for ``volatile`` operations"?


================
Comment at: docs/LangRef.rst:9726
+assumed to be reversible (i.e. casting the result back to the original
+address space should yield the original bit pattern).
 
----------------
I'm confused by:
> both source and destination address spaces are :ref:`integral pointers <nointptrtype>`

why are address spaces pointer types (or am I reading this wrong)?

Do we want "is assumed" and "should"? As above, that sounds like the are alternative options.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63525/new/

https://reviews.llvm.org/D63525