[PATCH] D57123: [MergeSets] Add infrastructure to build merge sets based on Das and Ramakrishna's paper.

[Aditya Kumar via Phabricator via llvm-commits]

hiraditya requested changes to this revision.
hiraditya added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/include/llvm/Analysis/MergeSets.h:82
+  /// Compute merge sets for CFG rooted at \p Root using TDMSC-I from the paper.
+  void build(BasicBlock *Root);
+
----------------
We can use a more descriptive name here and below.


================
Comment at: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:553
   Function &F = *DT.getRoot()->getParent();
-
+  /*  if (F.getName() == "gen_pic_list_from_frame_list")*/
+  // F.getParent()->dump();
----------------
nit: 


================
Comment at: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:668
+      }
+#ifndef NDEBUG
+      // Verify that we added the same number of  PHI nodes using merge sets as
----------------
can we put the code under #ifndef in separate function.


================
Comment at: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:825
   NewPhiNodes.clear();
+  /*  if (verifyFunction(F, &dbgs())) {*/
+  // F.dump();
----------------
nit:


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57123/new/

https://reviews.llvm.org/D57123