[PATCH] D68190: [llvm-mca] Add a -mattr flag

[Dave Green via Phabricator via llvm-commits]

dmgreen created this revision.
dmgreen added a reviewer: andreadb.
Herald added subscribers: gbedwell, tschuett.
Herald added a project: LLVM.

This adds a -mattr flag to llvm-mca, for cases where the -mcpu option does not contain all optional features.


https://reviews.llvm.org/D68190

Files:
  llvm/test/tools/llvm-mca/ARM/m4-targetfeatures.s
  llvm/tools/llvm-mca/llvm-mca.cpp


Index: llvm/tools/llvm-mca/llvm-mca.cpp
===================================================================
--- llvm/tools/llvm-mca/llvm-mca.cpp
+++ llvm/tools/llvm-mca/llvm-mca.cpp
@@ -89,6 +89,11 @@
          cl::desc("Target a specific cpu type (-mcpu=help for details)"),
          cl::value_desc("cpu-name"), cl::cat(ToolOptions), cl::init("native"));
 
+static cl::opt<std::string>
+    MATTR("mattr",
+          cl::desc("Additional target features."),
+          cl::cat(ToolOptions));
+
 static cl::opt<int>
     OutputAsmVariant("output-asm-variant",
                      cl::desc("Syntax variant to use for output printing"),
@@ -322,7 +327,7 @@
     MCPU = llvm::sys::getHostCPUName();
 
   std::unique_ptr<MCSubtargetInfo> STI(
-      TheTarget->createMCSubtargetInfo(TripleName, MCPU, /* FeaturesStr */ ""));
+      TheTarget->createMCSubtargetInfo(TripleName, MCPU, MATTR));
   if (!STI->isCPUStringValid(MCPU))
     return 1;
 
Index: llvm/test/tools/llvm-mca/ARM/m4-targetfeatures.s
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-mca/ARM/m4-targetfeatures.s
@@ -0,0 +1,29 @@
+# NOTE: Assertions have been autogenerated by utils/update_mca_test_checks.py
+# RUN: llvm-mca -mtriple=arm-none-none-eabi -mcpu=cortex-m4 -mattr=+fp64 -instruction-tables < %s | FileCheck %s
+
+vadd.f32 s0, s2, s2
+vadd.f64 d0, d2, d2
+
+# CHECK:      Instruction Info:
+# CHECK-NEXT: [1]: #uOps
+# CHECK-NEXT: [2]: Latency
+# CHECK-NEXT: [3]: RThroughput
+# CHECK-NEXT: [4]: MayLoad
+# CHECK-NEXT: [5]: MayStore
+# CHECK-NEXT: [6]: HasSideEffects (U)
+
+# CHECK:      [1]    [2]    [3]    [4]    [5]    [6]    Instructions:
+# CHECK-NEXT:  1      1     1.00                        vadd.f32	s0, s2, s2
+# CHECK-NEXT:  1      1     1.00                        vadd.f64	d0, d2, d2
+
+# CHECK:      Resources:
+# CHECK-NEXT: [0]   - M4Unit
+
+# CHECK:      Resource pressure per iteration:
+# CHECK-NEXT: [0]
+# CHECK-NEXT: 2.00
+
+# CHECK:      Resource pressure by instruction:
+# CHECK-NEXT: [0]    Instructions:
+# CHECK-NEXT: 1.00   vadd.f32	s0, s2, s2
+# CHECK-NEXT: 1.00   vadd.f64	d0, d2, d2


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68190.222316.patch
Type: text/x-patch
Size: 2152 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190929/e87fa22f/attachment.bin>