[PATCH] D68122: [Alignment][NFC] Remove unneeded llvm:: scoping on Align types

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/CallingConvLower.h:426
   /// and alignment.
-  unsigned AllocateStack(unsigned Size, unsigned Alignment) {
-    const llvm::Align Align(Alignment);
-    StackOffset = alignTo(StackOffset, Align);
+  unsigned AllocateStack(unsigned Size, unsigned A) {
+    const Align Alignment(A);
----------------
Given that this is a public API it would be better to have a meaningful name - maybe use `Alignment` in the API and rename to `CheckedAlignment` in the implementation ?


================
Comment at: llvm/include/llvm/Support/OnDiskHashTable.h:211
     offset_type TableOff = Out.tell();
-    uint64_t N =
-        llvm::offsetToAlignment(TableOff, llvm::Align(alignof(offset_type)));
+    uint64_t N = llvm::offsetToAlignment(TableOff, Align(alignof(offset_type)));
     TableOff += N;
----------------
remve `llvm::`


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:509
   // sections and expected to be contiguous (e.g. ObjC metadata).
-  const llvm::Align Align = getGVAlignment(GV, DL);
+  const Align Align = getGVAlignment(GV, DL);
 
----------------
`Alignment` ?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2937
   // Emit an alignment directive for this block, if needed.
-  const llvm::Align Align = MBB.getAlignment();
-  if (Align != llvm::Align::None())
+  const Align Align = MBB.getAlignment();
+  if (Align != Align::None())
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68122/new/

https://reviews.llvm.org/D68122