[PATCH] D68151: [GlobalISel] Add an operand to memory intrinsics to denote the "tail" marker.

Fri Sep 27 16:34:14 PDT 2019

arsenm added a comment.

In D68151#1686700 <https://reviews.llvm.org/D68151#1686700>, @aemerson wrote:

> In D68151#1686689 <https://reviews.llvm.org/D68151#1686689>, @arsenm wrote:
>
> > In D68151#1686687 <https://reviews.llvm.org/D68151#1686687>, @arsenm wrote:
> >
> > > I'm somewhat worried about this wrt. eventually verifying intrinsics have the correct number of operands
> >
> >
> > At minimum the verifier should manually check this operand and manually verify these intrinsics
>
>
> I'll add the verifier checks for this as well. If we want a different solution in general then let's start a separate discussion. Maybe we can explore adding more flags to MachineInstr, or dedicated G_CALL opcode that has a bitfield operand that propagates the flags from the CallInst.

For AMDGPU I'm going to need a regbankselectable G_CALL at some point anyway

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68151/new/

https://reviews.llvm.org/D68151