[PATCH] D68047: [SampleFDO] Create a separate flag ProfileAccurateForProfSymList for handling profile symbol list

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 13:48:41 PDT 2019


wmi marked 3 inline comments as done.
wmi added inline comments.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:502
+  if (ProfAccForSymsInList)
     return !PSI->isColdCount(CallsiteTotalSamples);
   else
----------------
davidxl wrote:
> Add an assert here that profile-sample-accurate is not on?
I add an assertion in the caller of callsiteIsHot, so we can check the case that profile-sample-accurate is set in function attribute. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68047/new/

https://reviews.llvm.org/D68047





More information about the llvm-commits mailing list