[PATCH] D68159: [ThinLTO/WPD] Ensure devirtualized targets use promoted symbol when necessary

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 13:23:02 PDT 2019


tejohnson created this revision.
tejohnson added reviewers: pcc, davidxl.
Herald added subscribers: dang, dexonsmith, steven_wu, inglorion, Prazek, mehdi_amini.
Herald added a project: LLVM.

This fixes a hole in the handling of devirtualized targets that were
local but need promoting due to devirtualization in another module. We
were not correctly referencing the promoted symbol in some cases. Make
sure the code that updates the name also looks at the ExportedGUIDs set
by utilizing a callback that checks all conditions (the callback
utilized by the internalization/promotion code).


Repository:
  rL LLVM

https://reviews.llvm.org/D68159

Files:
  include/llvm/Transforms/IPO/WholeProgramDevirt.h
  lib/LTO/LTO.cpp
  lib/Transforms/IPO/WholeProgramDevirt.cpp
  test/ThinLTO/X86/Inputs/devirt_promote.ll
  test/ThinLTO/X86/devirt_promote.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68159.222235.patch
Type: text/x-patch
Size: 7322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190927/83c15cd8/attachment.bin>


More information about the llvm-commits mailing list