[PATCH] D67920: [PGO] Refactor Value Profiling into a plugin based oracle and create a well defined API for the plugins.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

One more minor nit about naming conventions. Otherwise it looks ok to me, but wait for David to sign off.



================
Comment at: llvm/lib/Transforms/Instrumentation/ValueProfileCollector.cpp:47
+class VPCPluginChain<Plugin_t, Ts...> : public VPCPluginChain<Ts...> {
+  Plugin_t Plugin;
+  using Base = VPCPluginChain<Ts...>;
----------------
No underscore


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67920/new/

https://reviews.llvm.org/D67920