[PATCH] D68066: [llvm-objdump] Further rearrange llvm-objdump sections for compatability

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht added a comment.

Thanks, sorry for missing the sections contents & dwarf output ordering. Fixed those and added tests for the missing pieces.

I didn't run `check-lld` when mailing, and it turns a lot of those test make frequent use of llvm-objdump. Most cases were just rearranging lines, but a few places required tweaking the matchers for variable captures.



================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:2094
+    printRelocations(O);
+  if (DynamicRelocations && !Disassemble)
+    printDynamicRelocations(O);
----------------
jhenderson wrote:
> Is there a test case for this behaviour, i.e. suppressing -R output (also -r) when --disassemble is specified?
`-r` is covered by `elf-disassemble-relocs.test`. I forked one that runs on a dynamic object and covers this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68066/new/

https://reviews.llvm.org/D68066