[PATCH] D68081: Allow update_test_checks.py to not scrub names
David Greene via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 27 11:32:45 PDT 2019
greened added a comment.
> I also don't see the value in this. With autogenerated checks, the name of the instructions shouldn't be required to tell if the test is getting the correct behaviour and preserving the names makes test checks much more fragile.
So here's the situation I ran into. I have hundreds of tests to update. I don't want to match all of the IR, just selected instructions. The current behavior of rewriting the operands with FileCheck variable names makes it difficult to delete parts of the IR. Maintaining the original names makes it easy to delete IR.
Perhaps there is another way to handle situations like this. I am open to ideas!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68081/new/
https://reviews.llvm.org/D68081
More information about the llvm-commits
mailing list