[PATCH] D52199: [profile] Install headers for custom runtime maintainers

[Vedant Kumar via Phabricator via llvm-commits]

vsk marked an inline comment as done.
vsk added inline comments.


================
Comment at: compiler-rt/include/CMakeLists.txt:33
+  set(PROFILE_HEADERS
+    ../lib/profile/InstrProfiling.h
+    ../lib/profile/InstrProfilingInternal.h
----------------
vsk wrote:
> delcypher wrote:
> > @vsk Minor nit. Any particular reason why those header files live under `lib` instead on under `include/` in the source tree?
> Not that I'm aware of -- this could be a nice chance to clean things up.
> 
> Unfortunately I'm having a bear of a time figuring out why the rest of the sanitizers don't seem to pass -I ${COMPILER_RT_SOURCE_DIR}/include, but still manage to find the right headers. The profile runtime isn't built with this -I -- I suppose I could just add it in the profile runtime's CMakeLists.txt (and that works), but feel like I'm missing something. Any chance you've stumbled into this before?
Oh, actually, it looks like the sanitizer implementations don't include their public interface headers on purpose. In light of that, it actually seems more consistent to keep the profile headers in `lib`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52199/new/

https://reviews.llvm.org/D52199