[PATCH] D68129: [SystemZ] Change -march=systemz to triple and fix mature-mc test

Kai Nacke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 05:02:20 PDT 2019


Kai created this revision.
Kai added a reviewer: uweigand.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

These two test cases use -march=systemz instead of a triple. In
particular, the used file format is then based on the default host
triple. This leads to different behaviour on different platforms.

The SystemZ implementation uses the integrated assembler for a
long time now. The mature-mc-support test can be fully enabled.


Repository:
  rL LLVM

https://reviews.llvm.org/D68129

Files:
  llvm/test/CodeGen/SystemZ/mature-mc-support.ll
  llvm/test/CodeGen/SystemZ/tail-call-mem-intrinsics.ll


Index: llvm/test/CodeGen/SystemZ/tail-call-mem-intrinsics.ll
===================================================================
--- llvm/test/CodeGen/SystemZ/tail-call-mem-intrinsics.ll
+++ llvm/test/CodeGen/SystemZ/tail-call-mem-intrinsics.ll
@@ -1,4 +1,4 @@
-; RUN: llc -march=systemz < %s | FileCheck %s
+; RUN: llc -mtriple=s390x-linux-gnu < %s | FileCheck %s
 
 ; CHECK-LABEL: tail_memcpy:
 ; CHECK: jg memcpy
Index: llvm/test/CodeGen/SystemZ/mature-mc-support.ll
===================================================================
--- llvm/test/CodeGen/SystemZ/mature-mc-support.ll
+++ llvm/test/CodeGen/SystemZ/mature-mc-support.ll
@@ -1,12 +1,10 @@
 ; Test that inline assembly is parsed by the MC layer when MC support is mature
 ; (even when the output is assembly).
-; FIXME: SystemZ doesn't use the integrated assembler by default so we only test
-; that -filetype=obj tries to parse the assembly.
 
-; SKIP: not llc -march=systemz < %s > /dev/null 2> %t1
-; SKIP: FileCheck %s < %t1
+; RUN: not llc -mtriple=s390x-linux-gnu < %s > /dev/null 2> %t1
+; RUN: FileCheck %s < %t1
 
-; RUN: not llc -march=systemz -filetype=obj < %s > /dev/null 2> %t2
+; RUN: not llc -mtriple=s390x-linux-gnu -filetype=obj < %s > /dev/null 2> %t2
 ; RUN: FileCheck %s < %t2
 
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68129.222132.patch
Type: text/x-patch
Size: 1270 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190927/fa6eb52d/attachment.bin>


More information about the llvm-commits mailing list