[PATCH] D67948: [LV] Interleaving should not exceed estimated loop trip count.

[Evgeniy via Phabricator via llvm-commits]

ebrevnov marked 2 inline comments as done and an inline comment as not done.
ebrevnov added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/interleave_short_tc.ll:1
+; Check that we won't interleave by more than "best known" estimated trip count.
+
----------------
ebrevnov wrote:
> reames wrote:
> > I would suggest using an autogenerate checks for these.  It'll be more verbose, but also more clear about the expected output.
> > 
> > See utils/update_test_checks.py and FileCheck's --check-prefix option for the three variations.
> > See utils/update_test_checks.py and FileCheck's --check-prefix option for the three variations.
> Not sure I understand what exactly you mean but this.
> 
> I know it is possible to have a dedicated prefix for common checks of two run lines and provide several prefixes to FileCheck. For example:
> ; RUN: opt <cmd1> | FileCheck --check-prefix=CHECK-COMMON,CHECK-SPECIFIC1
> ; RUN: opt <cmd2> | FileCheck --check-prefix=CHECK-COMMON,CHECK-SPECIFIC2
> 
> In my case I have three different runs with one common check. Is there a way to combine them?
> I would suggest using an autogenerate checks for these. It'll be more verbose, but also more clear about the expected output.

In fact I did use update_test_checks.py to generate initial checks and then manually removed all unrelated ones. I think that makes test less sensitive to side changes and it's easy to see what we actually care about.

On the other hand I do see benefit of having wider context without the need to run 'opt' by hands.

It would be  interesting to hear what others think in this regard.


================
Comment at: llvm/test/Transforms/LoopVectorize/interleave_short_tc.ll:65
+
+attributes #0 = { nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { argmemonly nounwind willreturn }
----------------
reames wrote:
> Please remove unnecessary aspects of test.
Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67948/new/

https://reviews.llvm.org/D67948