[llvm] r373062 - [UpdateTestChecks] Fix wildcard support on DOS prompts

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 27 03:04:16 PDT 2019


Author: rksimon
Date: Fri Sep 27 03:04:16 2019
New Revision: 373062

URL: http://llvm.org/viewvc/llvm-project?rev=373062&view=rev
Log:
[UpdateTestChecks] Fix wildcard support on DOS prompts

D64572 / rL365818 changed the way that the file paths were collected, which meant we lost the file pattern expansion necessary when working with DOS command prompt

Modified:
    llvm/trunk/utils/update_test_checks.py

Modified: llvm/trunk/utils/update_test_checks.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/update_test_checks.py?rev=373062&r1=373061&r2=373062&view=diff
==============================================================================
--- llvm/trunk/utils/update_test_checks.py (original)
+++ llvm/trunk/utils/update_test_checks.py Fri Sep 27 03:04:16 2019
@@ -76,13 +76,13 @@ def main():
     sys.exit(1)
   opt_basename = 'opt'
 
-  test_paths = []
   for test in args.tests:
     if not glob.glob(test):
-      common.warn("Test file '%s' was not found. Ignoring it." % (test,))
+      common.warn("Test file pattern '%s' was not found. Ignoring it." % (test,))
       continue
-    test_paths.append(test)
 
+  # On Windows we must expand the patterns ourselves.
+  test_paths = [test for pattern in args.tests for test in glob.glob(pattern)]
   for test in test_paths:
     if args.verbose:
       print('Scanning for RUN lines in test file: ' + test, file=sys.stderr)




More information about the llvm-commits mailing list