[PATCH] D67921: [ARM][MVE] Change VCTP operand

Fri Sep 27 00:12:03 PDT 2019

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

looks good to me

================
Comment at: test/CodeGen/Thumb2/LowOverheadLoops/basic-tail-pred.ll:111
 ; CHECK: vector.body:
 ; CHECK: [[ELEMS:%[^ ]+]] = phi i32 [ %N, %vector.ph ], [ [[REMAINING:%[^ ]+]], %vector.body ]
+; CHECK: [[VCTP:%[^ ]+]] = call <4 x i1> @llvm.arm.vctp32(i32 [[ELEMS]])
----------------
samparker wrote:
> SjoerdMeijer wrote:
> > Perhaps you can teach me some regexps....
> > 
> > I was expecting:  `[[REMAINING:%.*]]` or `[[REMAINING:%.+]]`
> > 
> > I don't see what we are matching 1 or more times, how we 'eat up' all characters with `[^ ]+`
> I understand it as, match anything but not a space - the caret being the not.
Ah yes, it matches the beginning of a line, or it's a 'not' inside brackets, which I didn't know... So, yep, that's another way to eat up characters; 

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67921/new/

https://reviews.llvm.org/D67921