[PATCH] D66969: Output XCOFF object text section

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:391
+  // table entries for a detailed description. Bits 0-3 is for symbol
+  // visibility. Bit 10 (0x0020) can be set if the symbol is a function in the
+  // old XCOFF32 interpretation. Otherwise bit 10 should be 0. Since we don't
----------------
DiggerLin wrote:
> hubert.reinterpretcast wrote:
> > Use the shorter version of the comment here too,
> changed as suggestion
There are some cases here of two consecutive spaces. It is not necessarily wrong, but we should be consistent.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:298
+    Asm.writeSectionData(W.OS, Csect.MCCsect, Layout);
+
+}
----------------
We have code that introduces alignment padding, so I suspect we should have code here to write out the padding.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-common.ll:84
 ; SYMS-NEXT:   Symbol {
-; SYMS-NEXT:     Index: [[#Index:]]
-; SYMS-NEXT:     Name: a
+; SYMS:          Index: [[#Index:]]{{[[:space:]].*}}Name: a
 ; SYMS-NEXT:     Value (RelocatableAddress): 0x0
----------------
I think this warrants more explanation. Is the ability of the regex to match non-space characters intended?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66969/new/

https://reviews.llvm.org/D66969