[PATCH] D68062: Propeller lld framework for basicblock sections

[Han Shen via Phabricator via llvm-commits]

shenhan added a comment.

In D68062#1683618 <https://reviews.llvm.org/D68062#1683618>, @ruiu wrote:

> Let me start from very high-level review comments before getting into the details of the actual code:
>
> - First and foremost, can you add a file comments to each file to explain what you are doing in the file? It doesn't have to be detailed, but giving an overview at the beginning of a file is generally very useful.


Thanks, Done.

> - As Michael pointed out in the RFC thread, we already have a similar feature (C3 ordering) in lld to order sections according to its graph structure. These two should probably be merged.

Yup, that is reasonable. We discussed the issue this morning and think it is feasible to merge the C3 ordering w/ part of our reordering algorithm. However, we probably will delay this until after we get the first version in.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68062/new/

https://reviews.llvm.org/D68062