[PATCH] D68043: [AArch64][GlobalISel] Support lowering variadic musttail calls

[Amara Emerson via Phabricator via llvm-commits]

aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:2266
+    // If we are vararg, and we haven't seen a musttail call, check if there's
+    // one in this block.
+    if (IsVarArg && !HasMustTailInVarArgFn) {
----------------
Can we extract this into a helper function?


================
Comment at: llvm/lib/Target/AArch64/AArch64CallLowering.cpp:868
+    // forward. We want these copies to happen *before* handling arguments.
+    // If we do it after, we could clobber a parameter.
+    //
----------------
Not sure what this means. The forwarded physregs could clobber the argument copies, or vice versa? How?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68043/new/

https://reviews.llvm.org/D68043