[PATCH] D68093: [clang-scan-deps][static analyzer] Support for clang --analyze in scan-deps

[Jan Korous via Phabricator via llvm-commits]

jkorous marked 4 inline comments as done.
jkorous added inline comments.


================
Comment at: clang/test/ClangScanDeps/static-analyzer.c:12
+#ifdef __clang_analyzer__
+#include "Inputs/analyze_header_input.h"
+#endif
----------------
arphaman wrote:
> Please use existing `Inputs/header.h` instead of adding a new empty file.
Good point!


================
Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:262
         }
+        // Support for static analyzer.
+        auto It = find(AdjustedArgs.begin(), AdjustedArgs.end(), "--analyze");
----------------
arphaman wrote:
> Clang's driver should pass this, otherwise users of the ScanDeps library won't be able to rely on this behavior if they don't use the `clang-scan-deps` tool, but just the library itself.
Thanks, I was thinking only about the tool.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68093/new/

https://reviews.llvm.org/D68093