[PATCH] D68097: [LNT] Remove dead code

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 12:28:13 PDT 2019


thopre created this revision.
thopre added reviewers: cmatthews, hubert.reinterpretcast, kristof.beyls.
thopre added a parent revision: D67821: [LNT] Python 3 support: use Python 2's division behavior.
thopre added a child revision: D67822: [LNT] Python 3 support: adapt to removal of execfile.

Remove 2 blocks of dead code in LNT:

- safediv() method which is not used anywhere
- setting of derive_stat attribute of a MatrixDataRequest which is not used by anything.


https://reviews.llvm.org/D68097

Files:
  lnt/server/ui/util.py
  lnt/server/ui/views.py


Index: lnt/server/ui/views.py
===================================================================
--- lnt/server/ui/views.py
+++ lnt/server/ui/views.py
@@ -1771,9 +1771,6 @@
             req.samples[s[1]].append(s[0])
             all_orders.add(s[1])
             order_to_id[s[1]] = s[2]
-        req.derive_stat = {}
-        for order, samples in req.samples.items():
-            req.derive_stat[order] = mean(samples)
     if not all_orders:
         abort(404, "No data found.")
     # Now grab the baseline data.
Index: lnt/server/ui/util.py
===================================================================
--- lnt/server/ui/util.py
+++ lnt/server/ui/util.py
@@ -12,13 +12,6 @@
     return "#%02x%02x%02x" % (r, g, b)
 
 
-def safediv(a, b, default=None):
-    try:
-        return a / b
-    except ZeroDivisionError:
-        return default
-
-
 def makeDarkerColor(h):
     return makeDarkColor(h, 0.50)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68097.222004.patch
Type: text/x-patch
Size: 920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190926/b5010968/attachment.bin>


More information about the llvm-commits mailing list