[PATCH] D68054: Regex: Add static convenience functions for "match" and "sub"

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 10:35:44 PDT 2019


nlguillemot marked an inline comment as done.
nlguillemot added inline comments.


================
Comment at: tools/sancov/sancov.cpp:127
+static const Regex SancovFileRegex("(.*)\\.[0-9]+\\.sancov");
+static const Regex SymcovFileRegex(".*\\.symcov");
 
----------------
thopre wrote:
> nlguillemot wrote:
> > Missed making these ones `const` in the previous commit, so updated them in this one.
> I know it's a small change but I'd rather you split it out in a separate patch which I'll approve gladly. This allow easier revert or cherry-pick.
Moved to a separate patch here: https://reviews.llvm.org/D68091


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68054/new/

https://reviews.llvm.org/D68054





More information about the llvm-commits mailing list