[PATCH] D68054: Regex: Add static convenience functions for "match" and "sub"

Nicolas Guillemot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 10:15:03 PDT 2019


nlguillemot updated this revision to Diff 221976.
nlguillemot added a comment.

- Added more comments to static match and static sub to clarify the return value and the error's value.
- Remove updates of "static Regex" -> "static const Regex", to do them in a future separate patch instead.
- Switch order of test lines in "ConvenienceFunctions" test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68054/new/

https://reviews.llvm.org/D68054

Files:
  include/llvm/Support/Regex.h
  lib/Support/FileCheck.cpp
  lib/Support/Regex.cpp
  lib/Transforms/Utils/SymbolRewriter.cpp
  tools/llvm-cov/CoverageFilters.cpp
  unittests/Support/RegexTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D68054.221976.patch
Type: text/x-patch
Size: 10330 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190926/be7d4d9c/attachment.bin>


More information about the llvm-commits mailing list