[PATCH] D68025: [MC][ARM] vscclrm disassembles as vldmia

Alexandros Lamprineas via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 10:06:28 PDT 2019


labrinea marked an inline comment as done.
labrinea added inline comments.


================
Comment at: llvm/test/MC/ARM/vscclrm-asm.s:7
+// RUN: not llvm-mc -triple=thumbv8.1m.main-none-eabi -mattr=+mve.fp,+8msecext -show-encoding < %s 2>%t \
+// RUN: | FileCheck --check-prefix=CHECK-MVE-FP %s
 
----------------
miyuki wrote:
> Why do we need a different prefix here? I.e. shouldn't the assembler behave the same way with "-mattr=+mve.fp,+8msecext" as with "-mattr=+8msecext"?
> Same question the disassembler.
Indeed, a separate label is not necessary. I will fix that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68025/new/

https://reviews.llvm.org/D68025





More information about the llvm-commits mailing list