[PATCH] D68075: Do not #error if no OS is #defined
Marshall Clow via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 26 09:56:56 PDT 2019
mclow.lists added a comment.
In D68075#1684174 <https://reviews.llvm.org/D68075#1684174>, @davezarzycki wrote:
> Hi @ldionne – That's a good question and I don't know the answer. If it's okay with you, I'd like to keep this change request narrowly focused on getting libcxx to work at all with freestanding environments.
"Narrowly focused" changes is how we end up with a twisty little maze of `#ifdef`s and code.
I would much prefer if at the end of the day we had a better code base. (that includes the features that you want).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68075/new/
https://reviews.llvm.org/D68075
More information about the llvm-commits
mailing list