[PATCH] D68087: [ELF] Set SectionBase::partition in processSectionCommands
Peter Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 26 09:47:37 PDT 2019
peter.smith added a comment.
LGTM too, one really trivial comment nit but just a readability suggestion so not that important.
================
Comment at: ELF/LinkerScript.cpp:516
+ // Set the partition field as what OutputSection::recordSection() does.
+ // Partitions cannot be used with the SECTIONS command, so this is always
----------------
Really trivial nit, I think the "as what" would be better as "the same way as" Suggest "Set the partition field the same way OutputSection::recordSection() does."
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68087/new/
https://reviews.llvm.org/D68087
More information about the llvm-commits
mailing list