[PATCH] D67602: GlobalISel: Handle llvm.read_register

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 09:36:20 PDT 2019


arsenm added a comment.

In D67602#1671346 <https://reviews.llvm.org/D67602#1671346>, @rengolin wrote:

> Added some context comments in D67601 <https://reviews.llvm.org/D67601>.
>
> For this one: why only AMDGPU tests? Would be good to have at least ARM32/64, since they should be working with GlobalIsel, no?


One target is sufficient for new feature additions

> Not sure what's the difference between buffer_store_dword and flat_store_dword to make a comment on that change.

GlobalISel doesn't yet implement the buffer_store path for older targets, but it's irrelevant for the actual test


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67602/new/

https://reviews.llvm.org/D67602





More information about the llvm-commits mailing list