[PATCH] D68061: [docs] Document pattern of using CHECK-SAME to skip irrelevant lines

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 26 01:50:11 PDT 2019


jhenderson added reviewers: thopre, MaskRay, probinson.
jhenderson added inline comments.


================
Comment at: llvm/docs/CommandGuide/FileCheck.rst:290
+
+Another common use case for "``CHECK-SAME:``" is to avoid writing matchers for
+irrelevant fields. For example, suppose you're writing a test which parses a
----------------
thopre wrote:
> Nit: rather than say that it is common, it might be better to say that CHECK-SAME is useful in dealing with X. Whether it is common or not does not seem very relevant.
Yeah, I agree with this. I wrote it for the first time a few months ago, and as far as I know, it was the first time it was used for this purpose (certainly I came up with it independently!), so "common" seems like a stretch at the moment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68061/new/

https://reviews.llvm.org/D68061





More information about the llvm-commits mailing list