[PATCH] D67867: [libc] Add few docs and implementation of strcpy and strcat.

Siva Chandra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 23:43:17 PDT 2019


sivachandra marked an inline comment as done.
sivachandra added inline comments.


================
Comment at: libc/include/math.h:18
+
+float acosf(float x);
+
----------------
MaskRay wrote:
> MaskRay wrote:
> > I'd prefer deleting empty lines among similar functions.
> I mean
> 
> ```
> double asin(double); // no blank line below
> float asinf(float);
> long double asinl(long double);
> ```
I like your suggestion, but I want to leave it as is for now. As we add implementations, I want to separate out those having implementations from those not. So, within the implemented ones, we should follow your suggestion of grouping similar functions. Eventually, the full set of functions will be grouped.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67867/new/

https://reviews.llvm.org/D67867





More information about the llvm-commits mailing list