[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

Wed Sep 25 22:19:27 PDT 2019

MaskRay added a comment.

Thank you and others who have contributed to the efforts! I hope this can fill some gap of the missing optimization opportunities by PGO.

I've seen two patches posted for lld now, this patch and D68062 <https://reviews.llvm.org/D68062>. To make it easier to review, please make them organized by "Edit Related Revisions..."
Some of comments in D68062 <https://reviews.llvm.org/D68062> are applicable to this patch as well. Use `isec` for `IS` variables, `osec` for `OS` variables, etc.

There is also a question whether we should make `--optimize-bb-jumps` the default. I'd suggest defaulting to `--no-optimize-bb-jumps`. The various tests updated with `--no-optimize-bb-jumps` is a concern to me. Non-propeller users probably don't want their instructions unexpectedly rewritten by the linker.

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065