[PATCH] D66724: [AIX]Emit function descriptor csect in assembly

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/AsmPrinter.h:115
+  /// The symbol for the current function descriptor on AIX. This is created
+  /// at the beginning of each call to runOnMachineFunction().
+  MCSymbol *CurrentFnDescSym = nullptr;
----------------
`runOnMachineFunction` reference seems out-of-date with the current patch.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1665
+    assert(TM.getTargetTriple().isOSAIX() && "Function descriptor is only"
+                                             " supported on AIX.");
+    // Get the function entry point symbol.
----------------
Assert also that `CurrentFnDescSym` is set.


================
Comment at: llvm/lib/MC/MCAsmInfoXCOFF.cpp:30
+bool MCAsmInfoXCOFF::isValidUnquotedName(StringRef Name) const {
+  // FIXME: remove this function when we stop using "TOC[TC0]" as a symbol name
+  // any more.
----------------
s/remove/Remove/;
s/any more//;


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66724/new/

https://reviews.llvm.org/D66724