[PATCH] D52199: [profile] Install headers for custom runtime maintainers

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 17:32:40 PDT 2019


delcypher added a comment.

@vsk other than the minor nit LGTM.



================
Comment at: compiler-rt/include/CMakeLists.txt:33
+  set(PROFILE_HEADERS
+    ../lib/profile/InstrProfiling.h
+    ../lib/profile/InstrProfilingInternal.h
----------------
@vsk Minor nit. Any particular reason why those header files live under `lib` instead on under `include/` in the source tree?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52199/new/

https://reviews.llvm.org/D52199





More information about the llvm-commits mailing list