[PATCH] D68047: [SampleFDO] Create a separate flag ProfileAccurateForProfSymList for handling profile symbol list

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 15:57:49 PDT 2019


davidxl added inline comments.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:134
+static cl::opt<bool> ProfileAccurateForProfSymList(
+    "profile-accurate-for-profsymlist", cl::Hidden, cl::ZeroOrMore,
+    cl::init(false),
----------------
davidxl wrote:
> profile-accurate-for-symbols-in-list ?
It should be true by default.


================
Comment at: lib/Transforms/IPO/SampleProfile.cpp:136
+    cl::init(false),
+    cl::desc("For symbols in profile symbol list, regard their profiles are "
+             "accurate. "));
----------------
are --> to be.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68047/new/

https://reviews.llvm.org/D68047





More information about the llvm-commits mailing list