[PATCH] D68054: Regex: Add static convenience functions for "match" and "sub"

[Nicolas Guillemot via Phabricator via llvm-commits]

nlguillemot marked 3 inline comments as done.
nlguillemot added inline comments.


================
Comment at: tools/sancov/sancov.cpp:127
+static const Regex SancovFileRegex("(.*)\\.[0-9]+\\.sancov");
+static const Regex SymcovFileRegex(".*\\.symcov");
 
----------------
Missed making these ones `const` in the previous commit, so updated them in this one.


================
Comment at: unittests/Support/RegexTest.cpp:20
 
+using RegexDeathTest = RegexTest;
+
----------------
This typedef might seem kind of redundant, but it's recommended by the googletest guide:

https://github.com/google/googletest/blob/master/googletest/docs/advanced.md#death-test-naming


================
Comment at: unittests/Support/RegexTest.cpp:177
+// Death tests rely on assert which is disabled in release mode.
+#ifndef NDEBUG
+
----------------
This style of conditionally executing death tests was copied from `AlignmentTest.cpp`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68054/new/

https://reviews.llvm.org/D68054