[PATCH] D67995: [MemorySSA] Avoid adding Phis in the presence of unreachable blocks.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.

Thanks!



================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:82
+        else if (IncomingAccess != SingleAccess)
+          UniqueIncomingAccess = false;
+        PhiOps.push_back(IncomingAccess);
----------------
nit: would it be simpler to keep a count of the unreachable blocks we saw (not adding anything to PhiOps), then if PhiOps.size() > 1, just adding `NumUnreachablePreds` LiveOnEntryDefs?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67995/new/

https://reviews.llvm.org/D67995