[PATCH] D67132: [PATCH] Improve support for atomicrmw and cmpxchg in C API.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wdng.

LGTM with nit



================
Comment at: llvm/lib/IR/Core.cpp:3658-3659
     return LI->setVolatile(isVolatile);
-  return cast<StoreInst>(P)->setVolatile(isVolatile);
+  else if (StoreInst *SI = dyn_cast<StoreInst>(P))
+    return SI->setVolatile(isVolatile);
+  else if (AtomicRMWInst *AI = dyn_cast<AtomicRMWInst>(P))
----------------
No else after return


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67132/new/

https://reviews.llvm.org/D67132