[PATCH] D67839: [FPEnv] Document requirement of function attributes with constrained floating point

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 25 12:10:27 PDT 2019


uweigand added a comment.

In D67839#1683038 <https://reviews.llvm.org/D67839#1683038>, @kpn wrote:

> In D67839#1681121 <https://reviews.llvm.org/D67839#1681121>, @uweigand wrote:
>
> > I agree with marking function call sites as "strictfp".
>
>
> Say, would this apply to all function call sites? Or just to ones that aren't intrinsics?


Hmm, I hadn't thought about intrinsics.  It probably doesn't matter much -- intrinsics usually already have well-defined semantics, that really cannot be changed by some attribute either.  (In particular, the constrained intrinsics already specify their exception semantics; what additional information would adding a strictfp attribute provide?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67839/new/

https://reviews.llvm.org/D67839





More information about the llvm-commits mailing list