[PATCH] D67853: [PowerPC][XCOFF] Fix expansion of LWZtoc Pseudo for AIX.

[Sean Fertile via Phabricator via llvm-commits]

sfertile marked an inline comment as done.
sfertile added inline comments.


================
Comment at: llvm/trunk/lib/Target/PowerPC/PPCAsmPrinter.cpp:696
+    // AIX uses the local symbol directly for the operand; that the symbol is
+    // accessed toc-relative is implicit.
+    if (IsAIX) {
----------------
hubert.reinterpretcast wrote:
> I would prefer if we mentioned "label" somewhere in the comment as the term that maps better in the context of AIX. The implicit property is also limited to certain contexts (the Assembler Language Reference describes the condition as use of the label as a displacement in a D-form instruction), and the comment is insufficiently qualified to make that clear.
> I would prefer if we mentioned "label" somewhere in the comment as the term that maps better in the context of AIX. 

Can you expand on that, I'm not sure what semantic difference there is between a local symbol and a local label. I considered them equivalent, but can be wrong.

>  The implicit property is also limited to certain contexts (the Assembler Language Reference describes the condition as use of the label as a displacement in a D-form instruction), and the comment is insufficiently qualified to make that clear.

What about:
```
// AIX uses the local symbol directly for the operand; that the symbol is
 // accessed toc-relative in a lwz instruction is implicit.
```



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67853/new/

https://reviews.llvm.org/D67853