[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 24 09:38:42 PDT 2019


atanasyan accepted this revision.
atanasyan added a comment.

LGTM. But before commit get more approvals. For example, from echristo, code owners of other targets, etc.

I would keep the as-is. In that case a target of such huge modifications looks a bit more clear.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66795/new/

https://reviews.llvm.org/D66795





More information about the llvm-commits mailing list