[PATCH] D67301: [LLD] [COFF] Use the unified llvm demangle frontend function. NFC.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a subscriber: compnerd.
rnk added a comment.

In D67301#1681906 <https://reviews.llvm.org/D67301#1681906>, @MaskRay wrote:

> Is there a scenario where both Itanium and Microsoft mangling schemes should be tried? (mingw?)


Well, I was pushing for exactly the opposite. The schemes are easily distinguished: leading `?` or leading `_+Z`. It's easy to imagine a user using LLD to link together mingw (or even just @compnerd's x86_64-windows-itanium objects) and MSVC COFF files into the same program as long as they only talk to each other through plain C symbols. If we just handle everything all at once, there's less likelihood that down the line someone will file a bug asking us to add the other scheme along some strange codepath.

Anyway, this is my viewpoint, but I'm not writing the code, so @mstorsjo, please do not feel obligated to push this any further. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67301/new/

https://reviews.llvm.org/D67301